Merged
Conversation
…hanOrEqual, and GreaterThanOrEqual Signed-off-by: FrozenlemonTee <1115306170@qq.com>
Signed-off-by: FrozenlemonTee <1115306170@qq.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for ordered comparison operations (<, >, <=, >=) for primitive<> values by wiring new comparison operation tags through the operations dispatcher/value invoker pipeline, plus unit tests to validate behavior.
Changes:
- Introduce new comparison operation tags (
LessThan,GreaterThan,LessThanOrEqual,GreaterThanOrEqual) and register their traits/bindings. - Add
operations::{less_than, greater_than, less_than_or_equal, greater_than_or_equal}APIs and corresponding operator overloads. - Extend basic operator tests to cover the new ordered comparisons (including mixed underlying/primitive operands).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/operations/impl.cppm |
Adds new comparison operation tags and enables them via traits<> specializations. |
src/operations/invoker.cppm |
Implements runtime value-layer comparison helpers and binds them for checked/unchecked/saturating policies. |
src/operations/operators.cppm |
Exposes new operations::* functions and adds <, >, <=, >= operator overloads that dispatch via the framework. |
tests/basic/operations/operators/test_framework_and_compound.cpp |
Adds test coverage for ordered comparisons on integer primitives and mixed primitive/underlying operands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.